From bb1d06eb204b1d1135fcddccd14f6306abcd7f72 Mon Sep 17 00:00:00 2001 From: Hiltjo Posthuma Date: Sat, 9 Mar 2019 12:39:10 +0100 Subject: pedantic snprintf() improvement POSIX says: "If an output error was encountered, these functions shall return a negative value and set errno to indicate the error." --- stagit-index.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'stagit-index.c') diff --git a/stagit-index.c b/stagit-index.c index accb1a5..cc70e4d 100644 --- a/stagit-index.c +++ b/stagit-index.c @@ -28,7 +28,7 @@ joinpath(char *buf, size_t bufsiz, const char *path, const char *path2) r = snprintf(buf, bufsiz, "%s%s%s", path, path[0] && path[strlen(path) - 1] != '/' ? "/" : "", path2); - if (r == -1 || (size_t)r >= bufsiz) + if (r < 0 || (size_t)r >= bufsiz) errx(1, "path truncated: '%s%s%s'", path, path[0] && path[strlen(path) - 1] != '/' ? "/" : "", path2); } -- cgit v1.2.3